Bug #270

No retry limit when registering endpoint

Added by Philipp Buluschek over 3 years ago. Updated over 3 years ago.

Status:Closed Start date:11/05/2014
Priority:Low Due date:
Assignee:Stefano Lenzi % Done:

0%

Category:zigbee.basedriver Spent time: -
Target version:org.aaloa.zb4osgi.zigbee.basedriver-0.8.0
Has a patch:No Has license agreement signed:No

Description

In AFLayer.createEndPoint(SenderIdentifier) the variable retry is supposed to limit the number of retries registering an endpoint. The registration process should stop and fail with an Exception when no successful registration could be made after the given number of retries.

I believe, the following needs fixing:
1. The retry variable is never incremented, so it doesn't do anything, in particular does not limit the retries.
2. result should be checked for null before calling if( result.getStatus() != 0 ){ (if null, retry with the same endpoint, maybe wait a bit in between retries)


Related issues

related to Bug #232: Endpoint registration on the dongle In Progress 12/17/2013

Associated revisions

Revision 1103
Added by Stefano Lenzi over 3 years ago

Created Test Unit for verifying that NPE is thrown and no retry attempt is performed ( refs #270 )

Revision 1104
Added by Stefano Lenzi over 3 years ago

Updating the code for better reability and using retry as expected ( refs #270 )

History

#1 Updated by Stefano Lenzi over 3 years ago

  • Category set to zigbee.basedriver
  • Status changed from New to In Progress
  • Assignee set to Stefano Lenzi
  • Target version set to org.aaloa.zb4osgi.zigbee.basedriver-1.X

#2 Updated by Stefano Lenzi over 3 years ago

  • Status changed from In Progress to Resolved

I have create the Test Unit and a fixing for the reported issue.

Please close the issue if you agree

#3 Updated by Stefano Lenzi over 3 years ago

  • Target version changed from org.aaloa.zb4osgi.zigbee.basedriver-1.X to org.aaloa.zb4osgi.zigbee.basedriver-0.8.0

Closing the issue

#4 Updated by Stefano Lenzi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF